validation: bundle CRDs are compared by definition key instead of name #32
Conversation
openshift-ci-robot
added
the
kind/bug
|
Looking good but hold for now. |
openshift-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
openshift-ci-robot
removed
the
do-not-merge/hold
| if len(crd.Spec.Versions) == 0 { | ||
| // Skip group, which CSVs do not support. | ||
| key := registry.DefinitionKey{ | ||
| Name: crd.GetName(), |
There was a problem hiding this comment.
Our work adding v1 crds to bundles is going to break this - instead of returning a *v1beta1.CustomResourceDefinition we are returning an interface now. We started addressing this in https://github.com/operator-framework/api/pull/29/files#diff-8a818e661938b6d25ef2013d1289f89cR94
but I believe we are planning to move this code back into the registry instead - right @dinhxuanvu?
See operator-framework/operator-registry#295 for the PR with the breaking change. we are planning to merge this one this week.
We can merge as-is and then fix it in a follow-up, or hold off on this change.
There was a problem hiding this comment.
This PR is meant to fix api as it is. We will address the v1 CRD support in subsequent PR.
|
/lgtm |
|
/lgtm |
validation: bundle CRDs are compared by definition key instead of name (#32)
4 participants
CRDs should not be compared by name because each CSV
customresourcedefinitionelement is not unique by name only, i.e. multiple versions of the same CRD are allowed.Also fixed a test comparison (wrong argument order).
/kind bug
/cc @dinhxuanvu @kevinrizza