-
Notifications
You must be signed in to change notification settings - Fork 78
feat: bundle object validation #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
exdx
merged 1 commit into
operator-framework:master
from
exdx:feat/object-validation-checks
Sep 28, 2020
Merged
feat: bundle object validation #62
exdx
merged 1 commit into
operator-framework:master
from
exdx:feat/object-validation-checks
Sep 28, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
448df65
to
e8c2df3
Compare
e8c2df3
to
5b014d7
Compare
benluddy
reviewed
Sep 18, 2020
5b014d7
to
e9b359b
Compare
ecordell
reviewed
Sep 18, 2020
anik120
reviewed
Sep 18, 2020
pkg/validation/internal/testdata/objects/invalid_role_create_pdb.yaml
Outdated
Show resolved
Hide resolved
estroz
previously requested changes
Sep 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, mostly nits.
e9b359b
to
840e775
Compare
840e775
to
9077b9b
Compare
kevinrizza
reviewed
Sep 28, 2020
9077b9b
to
527bf81
Compare
/approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new validator type for object level validation in the bundle.