Skip to content

Conversation

exdx
Copy link
Contributor

@exdx exdx commented Sep 9, 2020

Adds new validator type for object level validation in the bundle.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2020
@exdx exdx force-pushed the feat/object-validation-checks branch 4 times, most recently from 448df65 to e8c2df3 Compare September 16, 2020 17:39
@exdx exdx marked this pull request as ready for review September 16, 2020 17:40
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2020
@exdx exdx force-pushed the feat/object-validation-checks branch from e8c2df3 to 5b014d7 Compare September 17, 2020 18:56
@exdx exdx force-pushed the feat/object-validation-checks branch from 5b014d7 to e9b359b Compare September 18, 2020 15:38
@exdx exdx requested a review from benluddy September 18, 2020 15:38
estroz
estroz previously requested changes Sep 18, 2020
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, mostly nits.

@exdx exdx force-pushed the feat/object-validation-checks branch from e9b359b to 840e775 Compare September 18, 2020 18:01
@exdx exdx requested review from estroz, anik120 and ecordell September 18, 2020 18:01
@exdx exdx force-pushed the feat/object-validation-checks branch from 840e775 to 9077b9b Compare September 18, 2020 18:49
@exdx exdx force-pushed the feat/object-validation-checks branch from 9077b9b to 527bf81 Compare September 28, 2020 18:12
@kevinrizza
Copy link
Member

/approve

@exdx exdx merged commit 87cbe73 into operator-framework:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants