Add a "properties" field to bundle lookups. #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If present, operator property information needs to be persisted until bundle unpacking completes so that properties can be projected onto ClusterServiceVersions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If present, operator property information needs to be persisted until
bundle unpacking completes so that properties can be projected onto
ClusterServiceVersions.
This is an artifact of the fact that the on-cluster representation of an installed operator (ClusterServiceVersion) is inflated from a manifest that is contained within a bundle. The need for this may eventually be obviated by directly writing to
Operatorresources, but given that the lack of property projection is responsible for fairly serious dependency resolution problems today, I think that this medium-term solution makes sense. I have written a brief summary of property projection here.