Skip to content

Conversation

exdx
Copy link
Contributor

@exdx exdx commented Oct 19, 2020

Allow users to pass in the path to a json-encoded file of categories via the environmental variable OPERATOR_BUNDLE_CATEGORIES when performing optional operatorhub UI validation for CSV categories. These categories will only be used for validation if they are provided. The existing default categories will be used for validation if no custom category file is provided.

The categories should be provided as a json encoded file with the following structure:

{
   "categories":[
      "Cloud Pak",
      "Registry",
      "MyCoolThing",
   ]
}

@exdx exdx requested a review from kevinrizza October 19, 2020 19:37
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2020
@exdx exdx force-pushed the feat/custom-categories branch 2 times, most recently from 8adbaae to 113e4dc Compare October 20, 2020 18:08
@exdx exdx marked this pull request as ready for review October 20, 2020 18:08
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2020
Copy link
Member

@kevinrizza kevinrizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment, otherwise this looks good to me.

@exdx exdx force-pushed the feat/custom-categories branch from 113e4dc to c880f35 Compare October 20, 2020 20:36
@exdx exdx requested a review from kevinrizza October 20, 2020 20:36
@kevinrizza
Copy link
Member

/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants