Bug 1891898: Set min and max values on Webhook Container Port #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OLM logs when a CSV with an invalid containerPort is created: |
awgreene
force-pushed
the
webhook-port-values
branch
from
28edde2 to
0e214c9
Compare
awgreene
force-pushed
the
webhook-port-values
branch
from
0e214c9 to
652cd68
Compare
|
/lgtm |
Problem: Operator Authors can create CSVs that define Webhooks with containerPorts set outside the range of 0-65535, which prevents the ValidatingWebhookConfiguration or MutatingWebhookConfiguration from being created due to failed validation. Solution: Update the CSV's CRD Validation to include the proper min and max values for webhookDescription ContainerPort field.
awgreene
force-pushed
the
webhook-port-values
branch
from
652cd68 to
3b25e5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Operator Authors can create CSVs that define Webhooks with
containerPorts set outside the range of 0-65535, which prevents the
ValidatingWebhookConfiguration or MutatingWebhookConfiguration from
being created due to failed validation.
Solution: Update the CSV's CRD Validation to include the proper min and
max values for webhookDescription ContainerPort field.
Example OLM Failure Log: