Introduce new OperatorCondition CRD #74
Conversation
| // +kubebuilder:storageversion | ||
| // +kubebuilder:subresource:status | ||
| // OperatorCondition is a Custom Resource of type `OperatorCondition` which is used to convey information to OLM about the state of an operator. | ||
| type OperatorCondition struct { |
There was a problem hiding this comment.
Condition struct was already defined.
We should probably document this here and link that PR here so that we can merge both of them together/at least one right after the other. |
pkg/operators/v1/condition_types.go
Outdated
|
|
||
| // OperatorConditionSpec allows a cluster admin to convey information about the state of an operator to OLM, potentially overriding state reported by the operator. | ||
| type OperatorConditionSpec struct { | ||
| Overrides []Condition `json:"overrides,omitempty"` |
There was a problem hiding this comment.
Should we add a TODO on the Condition type to migrate to metav1.Condition when we move everything to k8s 1.19+?
Is there anything that would prevent us from doing that? (e.g. a breaking change)
There was a problem hiding this comment.
We could use the metav1.Condition but we should be recognize that OLM's condition type has different fields:
- OLM's Condition has the
LastUpdateTimefield. - The metav1.Condition has the
ObservedGenerationfield.
If we plan to update this struct to use the metav1.Condition we will have to handle any CRs that have set the LastUpdateTime field. Thoughts?
There was a problem hiding this comment.
I would definitely opt for using metav1.Condition directly. We should diverge as little as possible. If we find that LastUpdateTime is actually useful, then we can create a composite struct that embeds metav1.Condition.
There was a problem hiding this comment.
to add to this, I was planning on replacing the Condition struct you're using w/ metav1.Condition at some point down the road as well.
awgreene
force-pushed
the
condition-crd
branch
2 times, most recently
from
accde41 to
40a9220
Compare
awgreene
force-pushed
the
condition-crd
branch
3 times, most recently
from
2fc06a7 to
a8a46e2
Compare
This commit introduces the OperatorCondition CRD which is used by an operator to communicate state to OLM.
awgreene
force-pushed
the
condition-crd
branch
from
a8a46e2 to
775018b
Compare
|
/approve |
|
/QE-approved |
10 participants
This commit introduced the OperatorCondition CRD which allows operators
to communicate advanced state directly with OLM.