Skip to content

Conversation

gallettilance
Copy link
Member

@gallettilance gallettilance commented Nov 20, 2020

The missing csv spec.icon field is now a warning (was a failure)
The csv metadata.annotations.categories field tolerates extra spaces at the start and end of the category

Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2020
@gallettilance
Copy link
Member Author

needs #77 to merge first

@dirgim
Copy link

dirgim commented Nov 20, 2020

/lgtm

@openshift-ci-robot
Copy link

@dirgim: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2020
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2020
@gallettilance gallettilance merged commit f55ec86 into operator-framework:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants