Skip to content

Conversation

exdx
Copy link
Contributor

@exdx exdx commented Dec 2, 2020

Extra test output writes to stderr in GH actions and causes the unit test output to produce erroneous error messages.
Removing these test logs (which just log the name of the test) removes errors from the unit test output:

--- PASS: TestValidateObject (0.00s)
Error:     object_test.go:67: valid PDB
Error:     object_test.go:67: invalid PDB - minAvailable set to 100%
Error:     object_test.go:67: invalid PDB - maxUnavailable set to 0
Error:     object_test.go:67: valid priorityclass
Error:     object_test.go:67: invalid priorityclass - global default set to true
Error:     object_test.go:67: valid pdb role
Error:     object_test.go:67: invalid role - modify pdb
Error:     object_test.go:67: valid scc role
Error:     object_test.go:67: invalid scc role - modify default scc

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@dinhxuanvu dinhxuanvu merged commit b55a341 into operator-framework:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants