Skip to content

Conversation

estroz
Copy link
Member

@estroz estroz commented Dec 8, 2020

Waiting on controller-runtime v0.8.0 to be released.

/cc @varshaprasad96

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 8, 2020
@awgreene
Copy link
Member

awgreene commented Dec 9, 2020

Should you update the CRDs to reflect the changes introduced by the change?

@awgreene
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2020
@estroz estroz marked this pull request as ready for review December 14, 2020 19:47
@openshift-ci-robot openshift-ci-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 14, 2020
@estroz estroz merged commit 0d3101d into operator-framework:master Dec 14, 2020
@estroz estroz deleted the deps/ks8-1-20 branch December 14, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants