FBC support #142
FBC support #142
Conversation
Pull Request Test Coverage Report for Build 3361633323
💛 - Coveralls |
| // check here to see if it's index.db or file-based catalogs | ||
| if isFBC() { | ||
| reportData, err = getDataFromFBC(reportData) | ||
| } else { | ||
| reportData, err = getDataFromIndexDB(reportData) | ||
| } |
There was a problem hiding this comment.
You may want to check out action.Render which supports rendering FBC structs from both SQLite and FBC images.
https://pkg.go.dev/github.com/operator-framework/operator-registry@v1.26.2/alpha/action#Render
There was a problem hiding this comment.
Hmm, that looks handy, would allow the reading sqlite code to go away, is there an example using it because I'm only seeing exported function of Run and Allowed? And the tests seem to assume a registry ref can be passed in, but if that's needed it would require more rework to the workflow than I think is warranted... I can see how to make use of a lot of the internal functions if they were externalized, esp: checkDBFile and sqliteToDeclcfg...
|
Okay, left this open for awhile, I'm going to merge it without the changes to preserve audit's internal workflow for now. |
Adds code to allow
auditto use file-based catalogs when encountered.NB: I went over a specific bundle carefully checking all the fields and values for a specific bundle from the 4.11 Red Hat index where both FBC and sqlite versions of the catalog exist. The only diffs at this point are noted in the comments in the code for both data loading functions (
getDataFromIndexDBandgetDataFromFBC). These diffs do not seem relevant to any reportingauditdoes.