Skip to content

Fix missing maxOCP for SQLite catalog #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Fix missing maxOCP for SQLite catalog #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cmd/index/eus/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,6 +465,7 @@ func remove(nonHeadBundles []string, headBundle string) []string {
}

func getMaxOcp(modelOrDb interface{}, channelGrouping channelGrouping) []string {
var maxOcpPerChannelSQL []string // already ordered
maxOcpPerChannel := make([]string, len(channelGrouping.ChannelNames))
switch modelOrDb := modelOrDb.(type) {
case *sql.DB:
Expand All @@ -477,18 +478,18 @@ func getMaxOcp(modelOrDb interface{}, channelGrouping channelGrouping) []string
return nil
}
if !row.Next() {
maxOcpPerChannel = append(maxOcpPerChannel, "")
maxOcpPerChannelSQL = append(maxOcpPerChannelSQL, "")
continue
} else {
var maxOpenShiftVersion string
err = row.Scan(&maxOpenShiftVersion)
if err == nil {
maxOcpPerChannel = append(maxOcpPerChannel, maxOpenShiftVersion)
maxOcpPerChannelSQL = append(maxOcpPerChannelSQL, stripQuotes([]byte(maxOpenShiftVersion)))
}
}
row.Close()
}
return maxOcpPerChannel
return maxOcpPerChannelSQL
case model.Model:
for _, Package := range modelOrDb {
if Package.Name == channelGrouping.OperatorName {
Expand Down