Skip to content

Conversation

camilamacedo86
Copy link
Collaborator

@camilamacedo86 camilamacedo86 commented Jul 15, 2021

By doing the work in the community operator we could check that when the property is set by the user with:

"olm.properties": '[{"type": "olm.maxOpenShiftVersion", "value": "4.8"}]'

Opm will add the value with the double cotes. That also needs to be solved in the validator.

IMPORTANT: it was not identified before because in the @gallettilance scripts we are inserting it directly and without the double coutes. However, that is not how opm will set the value when it is provided by the user.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1033429661

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.0008%) to 0.85%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/removed_apis.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/removed_apis.go 2 0%
Totals Coverage Status
Change from base Build 1027367761: 0.0008%
Covered Lines: 18
Relevant Lines: 2117

💛 - Coveralls

@camilamacedo86
Copy link
Collaborator Author

I am forcing this merge because the error faced in the CI here has no relation with the changes and I'd like to ask a help from team members

@camilamacedo86 camilamacedo86 merged commit 7b93173 into operator-framework:main Jul 15, 2021
@camilamacedo86 camilamacedo86 deleted the fix-check branch July 15, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants