feat: improve txt reports to allow us have a better information about the affected pkgs #70
Conversation
Pull Request Test Coverage Report for Build 1167479480
💛 - Coveralls |
… the affected pkgs
| generate-pkgs: install ## ensure that you have update the the date of the report. | ||
| go run ./hack/scripts/packages/generate.go --image=testdata/reports/redhat_certified_operator_index/bundles_registry.redhat.io_redhat_certified_operator_index_v4.9_2021-08-22.json | ||
| go run ./hack/scripts/packages/generate.go --image=testdata/reports/redhat_redhat_marketplace_index/bundles_registry.redhat.io_redhat_redhat_marketplace_index_v4.9_2021-08-22.json | ||
| go run ./hack/scripts/packages/generate.go --image=testdata/reports/redhat_certified_operator_index/bundles_registry.redhat.io_redhat_certified_operator_index_v4.8_2021-08-21.json |
There was a problem hiding this comment.
Maybe we should pass these in as env vars so it's not causing a git diff each time we want a new report target?
There was a problem hiding this comment.
Why should we inform the required input which changes for can each report generate via env var instead of use flags?
the audit tool is a CLI tool. It is using Cobra which allows us to easily create commands and have their flags. If you run --help you can check all optional flags and the values that you can inform.
The helper in the makefile needs to be updated with the JSON file every time that we add re-generate the reports. See the comment ensure that you have update the the date of the report. The Makefile here was added just to make it easier re-generate these reports and make clear/understandable how to do it for others in case I cannot do it and another person requires to run.
Also, see the comment description of the helper which appears via make --help This method should be removed soon. It is only an internal helper
| @@ -0,0 +1,383 @@ | |||
| ############################################## | |||
There was a problem hiding this comment.
It might be good if report data wasn't in a place that seems like it should have code hack/scripts/packages/ and it might be good to put it somewhere that is being gitignore'd -- it is just output of the tool, not source, right?
There was a problem hiding this comment.
The scripts directory will be fully removed after 4.9-GA.
If you look it is all deprecated. Why store the reports?
- Make easier: I do not need to re-gen that more than once when/if I need these data for the communications that we need to do before 4.9-GA.
- Be able to check the previous reports if/when required.
| # - The following results were obtained programmatically from: | ||
| # - Image name: registry.redhat.io/redhat/community-operator-index:v4.8 | ||
| # - Image ID: sha256:62e01b2214adbbcbad086b8e1e580cd8a95da4f6c904abeebf923fd52eb077c1 | ||
| # - Image Created at: 2021-08-20T21:38:31.852294899Z |
There was a problem hiding this comment.
same comment about gitignore'd and new location preferable
| @@ -0,0 +1,282 @@ | |||
| ############################################## | |||
There was a problem hiding this comment.
same comment about gitignore'd and new location preferable
| # - Image Created at: 2021-08-19T18:05:29.215979732Z | ||
| # - From JSON report generated at: 2021-08-21 | ||
| ############################################## | ||
| ------------------------------------- |
There was a problem hiding this comment.
same comment about gitignore'd and new location preferable
|
Hi @bentito, As we spoke I am moving forward here, but we can do changes afterwords by sure. Thank you for your time and review. |
No description provided.