Skip to content

(feat): create a new report to only monitor max ocp version and split the concerns #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2021
Merged

(feat): create a new report to only monitor max ocp version and split the concerns #76

merged 1 commit into from
Sep 7, 2021

Conversation

camilamacedo86
Copy link
Collaborator

@camilamacedo86 camilamacedo86 commented Sep 6, 2021 •
edited
Loading

(feat) : Split reports and keep one to monitor the max OCP version and another to monitor the deprecated apis

  • Now we have a dashboard to monitor the max OCP version set for the deprecate apis scenario
  • We simplified the deprecate api reports to use that to know what are the packages with compatible versions or not
  • We added a new flag to the custom dashboard reports to allow us to pass the template when required
  • We create a helper script to help us to verify the deprecations made.

@coveralls
Copy link

coveralls commented Sep 6, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1209231904

  • 0 of 89 (0.0%) changed or added relevant lines in 5 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.006%) to 0.832%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/reports/custom/custom_helpers.go 0 4 0.0%
pkg/reports/custom/deprecate_rules.go 0 7 0.0%
pkg/reports/custom/deprecated_api_report.go 0 10 0.0%
pkg/reports/custom/grade_report.go 0 13 0.0%
pkg/reports/custom/maxocp_api_report.go 0 55 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/reports/custom/custom_helpers.go 1 0%
pkg/reports/custom/deprecated_api_report.go 1 0%
pkg/reports/custom/deprecate_rules.go 2 0%
Totals Coverage Status
Change from base Build 1207258034: -0.006%
Covered Lines: 18
Relevant Lines: 2164
💛 - Coveralls

@camilamacedo86 camilamacedo86 changed the title (feat): add template flag for custom reports and the keep one for the bundle index (feat): create a new report to only monitor max ocp version and split the concerns Sep 6, 2021
@camilamacedo86
(feat) : Split reports and keep one to monitor the max ocp version an…
74be812 
…d another to monitor the deprecated apis

- Now we have a dashboard to monitor max ocp version set for the deprecate apis scenario
- We simplified the deprecate api reports to use that to know what are the packages with compatible versions or not
- We added a new flag to the custom dasboard reports to allow us to pass the template when required
- We create a helper script to verify the deprecations made
@camilamacedo86 camilamacedo86 merged commit 94b3f82 into operator-framework:main Sep 7, 2021
@camilamacedo86 camilamacedo86 deleted the flag branch September 7, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmccormick2001 jmccormick2001 jmccormick2001 approved these changes

@bparees bparees Awaiting requested review from bparees

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camilamacedo86 @coveralls @jmccormick2001