Proposal to add run bundle subcommand. #19
Conversation
|
|
||
| 1. if image doesn't have bash, we can't modify the entrypoint | ||
| 1. if opm is building index images without bash, then there will be no index | ||
| images we support |
There was a problem hiding this comment.
If we want to support redhat supported indexes, we should also check to see what their base image is. I know they are definitely doing some replacement there. @gallettilance
| * If `--index-image` is provided, use the provided value | ||
| * `[--namespace=]` is an optional flag that specifies the namespace to install | ||
| the operator. It will default to the `KUBECONFIG` context. | ||
| * `[--install-mode=]` is an optional flag that specifies the |
There was a problem hiding this comment.
The installModes are already defined by the bundle. I'm assuming this flag is for determining what OperatorGroup to generate - in that case, all we need is a --target-namespaces=[] arg taking the set of namespaces to watch (which matches the terminology in the OperatorGroup)
There was a problem hiding this comment.
We want someone to select the install mode to test not interface with the operator group I think was the thinking
There was a problem hiding this comment.
My point is that flag may be confusing. The flag is called installMode and the values are installMode values, but it does not set the installMode on the CSV (it can't, because that is already set in the bundle, and this command doesn't build the bundle).
What does this flag actually do?
There was a problem hiding this comment.
A user can set --install-mode=InstallModeType[=nsY]. If a bundle's CSV supports that mode in installModes by comparing type strings, run bundle will either create an OperatorGroup in some namespace targeting nsY, or use an existing and compatible OperatorGroup.
I see where this can create confusion: a supported mode in installModes is only a statement about runtime availability, whereas --install-mode mixes in OperatorGroup semantics.
I don't think it makes sense to pollute the CLI with two flags, one for installMode and another for namespaces to target/watch. We definitely need the latter, and we want the former so users see a mapping between the way they're testing operator deployment and what their CSV/bundle encodes, even though we could infer mode from passed namespaces.
7 participants
No description provided.