Skip to content

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Mar 25, 2022

No description provided.

@csviri csviri self-assigned this Mar 25, 2022
@csviri csviri force-pushed the docs-migration-to-v3 branch from f2aa6ed to 92bfafd Compare March 29, 2022 13:03
@csviri csviri force-pushed the docs-migration-to-v3 branch from 9a47bff to 1297ec5 Compare March 30, 2022 12:30
@csviri csviri marked this pull request as ready for review March 30, 2022 12:31
@csviri
Copy link
Collaborator Author

csviri commented Mar 30, 2022

This is quick list, will add continuously other other if I find one.

@csviri csviri requested a review from metacosm March 30, 2022 12:32
to a default name.
- [InformerEventSource](https://github.com/java-operator-sdk/java-operator-sdk/blob/92bfafd8831e5fb9928663133f037f1bf4783e3e/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java#L75-L75)
constructor changed to reflect additional functionality in a non backwards compatible way. But should be trivial to
migrate based on the new API.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saying it's trivial doesn't really help users. We should probably show how to migrate.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. added link for usage, and the configuration. The API is self explanatory, and should be very easy to migrate based on those.

csviri and others added 6 commits March 31, 2022 11:21
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
…tor/api/reconciler/ControllerConfiguration.java

Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
@csviri csviri requested a review from metacosm March 31, 2022 09:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@csviri csviri merged commit d24715d into main Mar 31, 2022
@csviri csviri deleted the docs-migration-to-v3 branch March 31, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants