feat: limited build to k8s >= 1.20.x #1230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
reviewed
May 20, 2022
.github/workflows/pr.yml
Outdated
| @@ -33,7 +33,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| java: [ 11, 17 ] | |||
| kubernetes: [ 'v1.17.17','v1.18.20','v1.19.16','v1.20.15','v1.21.12', 'v1.22.9', 'v1.23.6', 'v1.24.0' ] | |||
| kubernetes: ['v1.20.15','v1.21.12', 'v1.22.9', 'v1.23.6', 'v1.24.0' ] | |||
| exclude: | |||
| - java: 11 | |||
| kubernetes: 'v1.18.20' | |||
There was a problem hiding this comment.
You also need to remove these excludes that are not needed anymore…
There was a problem hiding this comment.
ahh, yes, thx. done.
There was a problem hiding this comment.
btw, its not clear to me why exactly those are excluded, what is the rational behind those values? I mean why are those exactly excluded.
Should be there just the oldest and the newest not excluded for java 11? @metacosm
There was a problem hiding this comment.
I guess the idea was to test only the latest versions with java 11 to limit the CI intensity.
|
Kudos, SonarCloud Quality Gate passed!
|
metacosm
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.