Primary to Secondary Mapper #1300
Conversation
| primaryToSecondaryIndex = | ||
| new PrimaryToSecondaryIndex<>(configuration.getSecondaryToPrimaryMapper()); | ||
| } else { | ||
| primaryToSecondaryIndex = null; |
There was a problem hiding this comment.
Maybe it'd be cleaner to have a no-op index instead of setting it to null and having to guard for null everywhere else?
There was a problem hiding this comment.
Not sure about that, it is very explicit this way, that the index is not used in that case.
There was a problem hiding this comment.
But also fine with that. Will try how that looks.
There was a problem hiding this comment.
There was a problem hiding this comment.
One doesn't prevent the other: we could have a NOOP index and still be able to make it explicit when needed (i.e. useSecondaryToPrimaryIndex could check if the set index is the NOOP one instead of null where we need to know for sure whether to use it or not). Not a showstopper in any case.
|
Attila, thank you very much for the prompt fix, I have tested this PR locally. I can confirm this addresses the issue we hit in FLINK-28008. Do you already have an ETA for the 3.0.3 patch release? |
@morhidi thx for feedback, glad to hear, after this issue is merged we can release v3.0.3, hopefully today or Monday. |
|
Kudos, SonarCloud Quality Gate passed! |
see related issue