Skip to content

fix: issue with post condition in workflow execution delete #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2022
Merged

fix: issue with post condition in workflow execution delete #1449

merged 2 commits into from
Sep 9, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Sep 9, 2022

No description provided.

@csviri csviri linked an issue Sep 9, 2022 that may be closed by this pull request
Flaky unit test: WorkflowReconcileExecutorTest.diamondDeleteWithPostConditionInMiddle #1368
Closed
@csviri csviri self-assigned this Sep 9, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.0% 90.0% Coverage
0.0% 0.0% Duplication

metacosm
metacosm reviewed Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it'd be interesting to add a unit test to cover this case since we didn't catch that issue with the existing tests.

@csviri
Copy link
Collaborator Author

csviri commented Sep 9, 2022 •
edited
Loading

LGTM but it'd be interesting to add a unit test to cover this case since we didn't catch that issue with the existing tests.

The related issue is about the faling test.
It was just with concurrency.

@csviri csviri merged commit f16ab52 into main Sep 9, 2022
@csviri csviri deleted the workflow-executor-fix branch September 9, 2022 09:02
metacosm pushed a commit that referenced this pull request Sep 14, 2022
@csviri @metacosm
fix: issue with post condition in workflow execution delete (#1449)
f8c881a
@csviri csviri mentioned this pull request Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm left review comments

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky unit test: WorkflowReconcileExecutorTest.diamondDeleteWithPostConditionInMiddle
2 participants
@csviri @metacosm