Skip to content

improvement: logging on informer stopping #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2023
Merged

improvement: logging on informer stopping #1726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...ework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
/** An interface from which to retrieve configuration information. */
public interface ConfigurationService {

Logger log = LoggerFactory.getLogger(ConfigurationService.class);

/**
* Retrieves the configuration associated with the specified reconciler
*
Expand Down Expand Up @@ -188,9 +190,10 @@ default Optional<InformerStoppedHandler> getInformerStoppedHandler() {
// hasSynced is checked to verify that informer already started. If not started, in case
// of a fatal error the operator will stop, no need for explicit exit.
if (ex != null && informer.hasSynced()) {
Logger log = LoggerFactory.getLogger(ConfigurationService.class);
log.error("Fatal error in informer: {}. Stopping the operator", informer, ex);
System.exit(1);
} else {
log.debug("Informer stopped: {}. Error: {}", informer, ex);
}
});
}
Expand Down