SchemaController: User PreparedStatements where possible #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use PreparedStatements where possible in the SchemaController in order to avoid SQL Injections. Note that PreparedSatements can only dynamically bind values and not object names, so this technique could only be applied to the queries, and not the DDL statements. The security around these statement can probably be improved by sanitizing the schema values, but it's out of the scope of this PR. As a side bonus, this PR also uses the try-with-resource idiom when creating these PreparedStatements and ResultSets so they will be properly closed instead of the current implementation that may leak resources. Closes operator-framework#120
|
Nicely done @mureinik ! thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
PreparedStatements where possible in theSchemaControllerin order to avoid SQL Injections.Note that
PreparedSatements can only dynamically bind values and not object names, so this technique could only be applied to the queries, and not the DDL statements. The security around these statements can probably be improved by sanitizing the schema values, but it's out of the scope of this PR.As a side bonus, this PR also uses the try-with-resource idiom when creating these
PreparedStatements andResultSets so they will be properly closed instead of the current implementation that may leak resources.Closes #120