improve: thread-safe idempotent dynamic informer event source start #2174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
changed the title
|
Can you elaborate on what this changes, please? |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Converted it to draft (meant it that way originally), until not finished. The reason for this is related to dynamic registration, if in a reconciliation multiple event sources are registered dynamically possible of same name from different thread (and also different type), it is hard to make that efficient ATM. Thus to not make all the threads possibly wait in the synchronized block of here. One way to do this si to query if the ES is already registered. But if registered does not mean it is started. By this change, calling the start method should ensure that it is started (in a thread-safe way) and also simultaneously waiting for the other thread if that is starting the event source. We can look on this as a lock striping. |
csviri
force-pushed
the
ies-idenpotet-sync-start
branch
from
3212130 to
4ae0266
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
this will allow to multiple threads wait idempotently for the start of an informer event source Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
force-pushed
the
ies-idenpotet-sync-start
branch
from
247a58f to
ac65a28
Compare
csviri
changed the title
metacosm
approved these changes
Jan 9, 2024
csviri
added a commit
that referenced
this pull request
Jan 10, 2024
…2174) * imrove: thread-safe idempotent informer event source start this will allow to multiple threads wait idempotently for the start of an informer event source Signed-off-by: Attila Mészáros <csviri@gmail.com> * improvements on dynamic registration Signed-off-by: Attila Mészáros <csviri@gmail.com> * signing Signed-off-by: Attila Mészáros <csviri@gmail.com> * decoration Signed-off-by: Attila Mészáros <csviri@gmail.com> * format Signed-off-by: Attila Mészáros <csviri@gmail.com> * minor changes Signed-off-by: Attila Mészáros <csviri@gmail.com> --------- Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
added a commit
that referenced
this pull request
Jan 10, 2024
…2174) Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
added a commit
that referenced
this pull request
Jan 10, 2024
…2174) Signed-off-by: Attila Mészáros <csviri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will allow to multiple threads wait idempotently for the start of an informer event source