-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next (v5) (DO NOT MERGE) #2203
Open
csviri
wants to merge
88
commits into
main
Choose a base branch
from
next
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
next (v5) (DO NOT MERGE) #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csviri
force-pushed
the
next
branch
2 times, most recently
from
January 25, 2024 10:32
f8441d9
to
b2caf28
Compare
openshift-merge-robot
added
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Jan 31, 2024
openshift-merge-robot
added
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
and removed
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
labels
Feb 5, 2024
openshift-merge-robot
removed
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Mar 7, 2024
openshift-merge-robot
added
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Mar 14, 2024
openshift-merge-robot
removed
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Apr 10, 2024
metacosm
force-pushed
the
next
branch
2 times, most recently
from
April 11, 2024 14:50
d7da94e
to
76046f7
Compare
openshift-merge-robot
added
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Apr 12, 2024
openshift-merge-robot
removed
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
May 17, 2024
csviri
force-pushed
the
next
branch
2 times, most recently
from
May 21, 2024 19:03
afe3d7d
to
cc57156
Compare
openshift-merge-robot
added
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
May 21, 2024
openshift-merge-robot
added
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
and removed
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
labels
Jun 17, 2024
openshift-merge-robot
added
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
and removed
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
labels
Jul 8, 2024
openshift-merge-robot
removed
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Jul 9, 2024
#2455) * feat: move controller informer-related configuration to InformerConfig Signed-off-by: Chris Laprun <claprun@redhat.com> * refactor: start isolating ResourceConfiguration Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: initFromAnnotation now properly inits the current instance Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: default onDeleteFilter implementation Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: properly set default namespaces in controller case Signed-off-by: Chris Laprun <claprun@redhat.com> * refactor: remove KubernetesDependentInformerConfigBuilder Signed-off-by: Chris Laprun <claprun@redhat.com> * refactor: use InformerConfigHolder in more places, unifying handling Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: properly propagate name to informer config Signed-off-by: Chris Laprun <claprun@redhat.com> * feat: add factory method to init builder from an extising configuation Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: remove potentially problematic default implementation Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Chris Laprun <claprun@redhat.com>
Fixes #2424. --------- Signed-off-by: Attila Mészáros <csviri@gmail.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Attila Mészáros <csviri@gmail.com> Signed-off-by: Chris Laprun <claprun@redhat.com>
--------- Signed-off-by: 10000-ki <10000ki6472@gmail.com>
… based on type (#2483) * refactor: integration tests moved to feature packages and sub packages pased on type Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fix resource paths Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * link and test fixes Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * format Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * wip Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * old service Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * test fix Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * refactor: remove unneeded classes Signed-off-by: Chris Laprun <claprun@redhat.com> * fix: typo in package name Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Chris Laprun <claprun@redhat.com>
* chore: set version to 5.0.0-SNAPSHOT (#2200) Signed-off-by: Attila Mészáros <csviri@gmail.com> * improve: replace current formatting plugins with spotless plugin (#2302) Signed-off-by: Attila Mészáros <csviri@gmail.com> * fix: format after rebase Signed-off-by: Attila Mészáros <csviri@gmail.com> * bump: chore use slf4j v2 (#2406) Signed-off-by: Attila Mészáros <csviri@gmail.com> * feat: allow returning additional information from conditions (#2426) Fixes #2424. --------- Signed-off-by: Attila Mészáros <csviri@gmail.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Attila Mészáros <csviri@gmail.com> Signed-off-by: Chris Laprun <claprun@redhat.com> * refactor: move @InformerConfig to more appropriate package Signed-off-by: Chris Laprun <claprun@redhat.com> * refactor: move InformerConfigHolder to appropriate package Signed-off-by: Chris Laprun <claprun@redhat.com> * chore: remove unneeded code & dependencies Signed-off-by: Chris Laprun <claprun@redhat.com> * refactor: InformerConfiguration to InformerEventSourceConfiguration Signed-off-by: Chris Laprun <claprun@redhat.com> * refactor: rename inner InformerConfigurationBuilder to simply Builder Signed-off-by: Chris Laprun <claprun@redhat.com> * refactor: rename InformerConfig and associated field to Informer Signed-off-by: Chris Laprun <claprun@redhat.com> * refactor: rename InformerConfigHolder to InformerConfiguration Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Attila Mészáros <csviri@gmail.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
* feat: config option to not exit when stops leading Signed-off-by: Attila Mészáros <a_meszaros@apple.com> * Update operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com> --------- Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
--------- Signed-off-by: Attila Mészáros <csviri@gmail.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Signed-off-by: Attila Mészáros <a_meszaros@apple.com> Co-authored-by: Attila Mészáros <csviri@gmail.com> Co-authored-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Matt Riben <matt.riben@swirldslabs.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
* feat: explicit node configuration in WorkflowBuilder Fixes #2284 Signed-off-by: Chris Laprun <claprun@redhat.com> * refactor: rename more appropriately Signed-off-by: Chris Laprun <claprun@redhat.com> --------- Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
* imporve diff logging Signed-off-by: bachmanity1 <bachmanity138@gmail.com> * compute diff only when actual doesn't match desired Signed-off-by: bachmanity1 <bachmanity138@gmail.com> * slight improvements Signed-off-by: bachmanity1 <bachmanity138@gmail.com> * increase context size Signed-off-by: bachmanity1 <bachmanity138@gmail.com> * fix style Signed-off-by: bachmanity1 <bachmanity138@gmail.com> * calculate diff only if debug is enabled Signed-off-by: bachmanity1 <bachmanity138@gmail.com> * print actual resources when trace is enabled Signed-off-by: bachmanity1 <bachmanity138@gmail.com> * use java-diff-utils Signed-off-by: bachmanity1 <bachmanity138@gmail.com> * add unit tests --------- Signed-off-by: bachmanity1 <bachmanity138@gmail.com>
openshift-merge-robot
removed
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Oct 10, 2024
Signed-off-by: Chris Laprun <claprun@redhat.com>
* feat(build): split ITs by category, parallel CRD generation Also avoid generating CRDs when not needed by default, summarizes test results. * chore(deps): bump actions-setup-minikube to 2.13.0 * feat: default to use vertx client * chore(ci): reduce tested combinations, only run client tests on baseapi * fix: increase deletion timeout --------- Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
openshift-merge-robot
added
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Nov 3, 2024
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.