Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Workflow extracted to a separate annotation #2274

Merged
merged 2 commits into from
Mar 11, 2024
Merged

feat: Workflow extracted to a separate annotation #2274

merged 2 commits into from
Mar 11, 2024

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Mar 8, 2024

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2024
This was linked to issues Mar 8, 2024
Rename dependents to workflow in @ControllerConfiguration in v5 #1773
Closed
Custom Invocation of Managed Workflows #1898
Closed
@csviri csviri marked this pull request as ready for review March 8, 2024 16:07
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2024
@csviri csviri mentioned this pull request Mar 8, 2024
Closed
@csviri csviri requested a review from metacosm March 11, 2024 09:27
metacosm
metacosm approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should make the ControllerConfiguration annotation optional as well.

@csviri
Copy link
Collaborator Author

csviri commented Mar 11, 2024

Maybe we should make the ControllerConfiguration annotation optional as well.

yeah, would make sense, could you create an issue pls?

@metacosm metacosm mentioned this pull request Mar 11, 2024
Closed
@csviri
feat: Workflow extracted to a separate annotation
8cfa16c 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
refactor to use workflow everywhere
d34a9f1 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri csviri force-pushed the separate-workflow-annotation branch from 0fe0f33 to d34a9f1 Compare March 11, 2024 18:34
@csviri csviri merged commit e0a622f into next Mar 11, 2024
20 checks passed
@csviri csviri deleted the separate-workflow-annotation branch March 11, 2024 19:16
csviri added a commit that referenced this pull request Mar 11, 2024
@csviri
feat: Workflow extracted to a separate annotation (#2274)
c67ca26 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm metacosm mentioned this pull request Mar 21, 2024
Closed
csviri added a commit that referenced this pull request Apr 10, 2024
@csviri
feat: Workflow extracted to a separate annotation (#2274)
6ba4d20 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Apr 10, 2024
@csviri @metacosm
feat: Workflow extracted to a separate annotation (#2274)
2caa4f6 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Apr 11, 2024
@csviri @metacosm
feat: Workflow extracted to a separate annotation (#2274)
c801910 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request May 17, 2024
@csviri
feat: Workflow extracted to a separate annotation (#2274)
b195bdc 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request May 17, 2024
@csviri
feat: Workflow extracted to a separate annotation (#2274)
a87ae85 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request May 21, 2024
@csviri
feat: Workflow extracted to a separate annotation (#2274)
b8d0668 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri added a commit that referenced this pull request Jun 17, 2024
@csviri
feat: Workflow extracted to a separate annotation (#2274)
c09ee78 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Jul 8, 2024
@csviri @metacosm
feat: Workflow extracted to a separate annotation (#2274)
9675b7f 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Jul 9, 2024
@csviri @metacosm
feat: Workflow extracted to a separate annotation (#2274)
1ffe3ff 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
metacosm pushed a commit that referenced this pull request Jul 12, 2024
@csviri @metacosm
feat: Workflow extracted to a separate annotation (#2274)
9b1310b 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

@andreaTP andreaTP Awaiting requested review from andreaTP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Invocation of Managed Workflows Rename dependents to workflow in @ControllerConfiguration in v5
2 participants
@csviri @metacosm