Skip to content

update Tomcat sample to use EventSources #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 17, 2020
Merged

update Tomcat sample to use EventSources #256

merged 7 commits into from
Dec 17, 2020

Conversation

adam-sandor
Copy link
Collaborator

Sample demonstrating multiple Controllers and EventSource on Deployments.

@csviri
Copy link
Collaborator

csviri commented Dec 17, 2020

@adam-sandor I'm not convinced we need to put this back, I would keep it in the separate repo.
@psycho-ir @metacosm what do you think?

@adam-sandor
Copy link
Collaborator Author

I would do the update here, because that's where all the samples are, then move it to where we agree to put them.

@csviri
Copy link
Collaborator

csviri commented Dec 17, 2020

@adam-sandor but we already moved this to a separate repo. Don't understand why we want to put this back.
( https://github.com/java-operator-sdk/tomcat-operator )

@adam-sandor
Copy link
Collaborator Author

It was never removed so I'm not really moving it back. I would like to deprecate the tomcat-operator repo.

@csviri
Copy link
Collaborator

csviri commented Dec 17, 2020

kk, then its fine.
However let's discuss what samples to keep here in main repo, since are more samples with no clear purpose. We should have clearly defined goal with each of them, since it takes time to maintain them.

Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metacosm metacosm merged commit 37dbf4a into master Dec 17, 2020
@metacosm metacosm deleted the tomcat-sample branch December 17, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants