feat(docs): add @Sample annotation for documentation #2954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marks integration test classes so that markdown pages can be auto generated.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
I wasn't sure where to place @sample, so I put it in a temporary module for now. I thought about putting it in sample-operators. Do you have any recommendations? I'm happy to move it. |
|
I think that is fine by now, since the implementation will be I guess an annotation processor. |
metacosm
requested changes
Sep 22, 2025
| <artifactId>operator-annotations</artifactId> | ||
|
|
||
| <properties> | ||
| <maven.compiler.source>22</maven.compiler.source> |
There was a problem hiding this comment.
I'm not sure these properties are needed here since they should probably be inherited from the parent. Also, this code should work with Java 21.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks integration test classes so that markdown pages can be auto generated.