Skip to content

fix: deactivate integration tests by default #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/master-snapshot-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
with:
java-version: ${{ matrix.java }}
- name: Run unit tests
run: mvn -B test -P no-integration-tests --file pom.xml
run: mvn -B test --file pom.xml
- name: Set up Minikube
uses: manusa/actions-setup-minikube@v2.3.0
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Check code format
run: mvn fmt:check --file pom.xml
- name: Run unit tests
run: mvn -B test -P no-integration-tests --file pom.xml
run: mvn -B test --file pom.xml
- name: Set up Minikube
uses: manusa/actions-setup-minikube@v2.3.0
with:
Expand Down
2 changes: 1 addition & 1 deletion docs/DOCS.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ version can be found under `samples/mysql-schema/README.md`.

1. Setup kubectl to work with your Kubernetes cluster of choice.
1. Apply Custom Resource Definition
1. Compile the whole project (framework + samples) using `mvn install -P no-integration-tests` in the root directory
1. Compile the whole project (framework + samples) using `mvn install` in the root directory
1. Run the main class of the sample you picked and check out the sample's README to see what it does.
When run locally the framework will use your Kubernetes client configuration (in ~/.kube/config) to make the connection
to the cluster. This is why it was important to set up kubectl up front.
Expand Down
14 changes: 7 additions & 7 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,11 @@
<version>${surefire.version}</version>
<configuration>
<includes>
<include>**/*IT.java</include>
<include>**/*Test.java</include>
</includes>
<excludes>
<exclude>**/*IT.java</exclude>
</excludes>
</configuration>
</plugin>
<plugin>
Expand All @@ -143,7 +145,7 @@

<profiles>
<profile>
<id>no-integration-tests</id>
<id>all-tests</id>
<build>
<plugins>
<plugin>
Expand All @@ -153,10 +155,8 @@
<configuration>
<includes>
<include>**/*Test.java</include>
<include>**/*IT.java</include>
</includes>
<excludes>
<exclude>**/*IT.java</exclude>
</excludes>
</configuration>
</plugin>
</plugins>
Expand All @@ -172,10 +172,10 @@
<version>${surefire.version}</version>
<configuration>
<includes>
<exclude>**/*IT.java</exclude>
<include>**/*IT.java</include>
</includes>
<excludes>
<include>**/*Test.java</include>
<exclude>**/*Test.java</exclude>
</excludes>
</configuration>
</plugin>
Expand Down
2 changes: 1 addition & 1 deletion samples/mysql-schema/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ the [Container Registry](https://cloud.google.com/container-registry/) in Google

1. The following Maven command will build the jar file, package it as a Docker image and push it to the registry.

`mvn -P no-integration-tests package dockerfile:build dockerfile:push`
`mvn package dockerfile:build dockerfile:push`

1. Deploy the test MySQL on your cluster if you want to use it. Note that if you have an already running MySQL server
you want to use, you can skip this step, but you will have to configure the operator to use that server.
Expand Down