Skip to content

Event handler waits a long time before terminating #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Event handler waits a long time before terminating #437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...mework-core/src/main/java/io/javaoperatorsdk/operator/processing/DefaultEventHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,8 @@ public class DefaultEventHandler implements EventHandler {
private final Map<String, RetryExecution> retryState = new HashMap<>();
private final String controllerName;
private final int terminationTimeout;
private DefaultEventSourceManager eventSourceManager;

private final ReentrantLock lock = new ReentrantLock();
private DefaultEventSourceManager eventSourceManager;

public DefaultEventHandler(
ResourceController controller, ControllerConfiguration configuration, MixedOperation client) {
Expand Down Expand Up @@ -91,6 +90,7 @@ private DefaultEventHandler(
public void close() {
try {
log.debug("Closing handler for {}", controllerName);
executor.shutdown();
executor.awaitTermination(terminationTimeout, TimeUnit.SECONDS);
} catch (InterruptedException e) {
log.debug("Exception closing handler for {}: {}", controllerName, e.getLocalizedMessage());
Expand Down