EventSourceManager small fix #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
approved these changes
Oct 4, 2021
| @@ -174,7 +174,7 @@ public void start() throws OperatorException { | |||
| } | |||
|
|
|||
| try { | |||
| DefaultEventSourceManager<R> eventSourceManager = new DefaultEventSourceManager<>(this); | |||
| eventSourceManager = new DefaultEventSourceManager<>(this); | |||
There was a problem hiding this comment.
Ah yes, I missed that when I made init throw an exception. Good catch!
|
Please rebase your PR so that all commits follow the conventional commit message format: https://www.conventionalcommits.org/en/v1.0.0/ |
csviri
force-pushed
the
access-event-source-manager
branch
from
4b15974 to
6a55b78
Compare
|
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need this for v2 branch, but this might make sense to v1.*