Scheduling no resource version compare #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-sandor
reviewed
Apr 22, 2020
| @@ -119,10 +114,11 @@ void scheduleEvent(CustomResourceEvent event) { | |||
| void eventProcessingFinishedSuccessfully(CustomResourceEvent event) { | |||
| try { | |||
| lock.lock(); | |||
| log.debug("Even processing successful for event: {}", event); | |||
adam-sandor
reviewed
Apr 22, 2020
| if (notScheduledYetEvent != null) { | ||
| scheduleEvent(notScheduledYetEvent); | ||
| if (eventStore.containsNotScheduledEvent(event.resourceUid())) { | ||
| log.debug("Scheduling not yet scheduled after previous successful processing: {}", event); |
There was a problem hiding this comment.
doesn't make sense.. try to rephrase
adam-sandor
reviewed
Apr 22, 2020
| scheduleEvent(notScheduledYetEvent); | ||
| if (eventStore.containsNotScheduledEvent(event.resourceUid())) { | ||
| CustomResourceEvent notScheduledEvent = eventStore.removeEventNotScheduledYet(event.resourceUid()); | ||
| log.debug("Even processing failed. Scheduling the most recent event. Failed event: {}," + |
adam-sandor
reviewed
Apr 22, 2020
| } else { | ||
| log.debug("Even processing failed. Attempting to re-schedule the event: {}", event); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.