fix: minor fixes #767
Merged
fix: minor fixes #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
reviewed
Dec 20, 2021
...or-framework-core/src/main/java/io/javaoperatorsdk/operator/api/ObservedGenerationAware.java
Outdated
Show resolved
Hide resolved
…tor/api/ObservedGenerationAware.java Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
metacosm
reviewed
Dec 20, 2021
...or-framework-core/src/main/java/io/javaoperatorsdk/operator/api/ObservedGenerationAware.java
Outdated
Show resolved
Hide resolved
metacosm
reviewed
Dec 20, 2021
...or-framework-core/src/main/java/io/javaoperatorsdk/operator/api/ObservedGenerationAware.java
Outdated
Show resolved
Hide resolved
…tor/api/ObservedGenerationAware.java Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
metacosm
reviewed
Dec 20, 2021
...mework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ErrorStatusHandler.java
Outdated
Show resolved
Hide resolved
metacosm
reviewed
Dec 20, 2021
...ator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Reconciler.java
Outdated
Show resolved
Hide resolved
…tor/api/reconciler/Reconciler.java Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
…tor/api/ObservedGenerationAware.java Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
…tor/api/reconciler/ErrorStatusHandler.java Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
metacosm
reviewed
Dec 20, 2021
Comment on lines
14
to
18
| * {@link UpdateControl#noUpdate()}. This the common use cases. However in cases, for | ||
| * example the operator is restarted, and we don't want to have an update call to k8s api | ||
| * to be made unnecessarily, by returning {@link UpdateControl#noUpdate()} this update can | ||
| * be skipped. <b>However we will always call an update if there is no finalizer on object | ||
| * and it's not marked for deletion.</b> |
There was a problem hiding this comment.
This part isn't clear to me… :(
There was a problem hiding this comment.
changed, simpliefied mostly. This indeed does not make sense.
metacosm
reviewed
Dec 20, 2021
...ator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Reconciler.java
Outdated
Show resolved
Hide resolved
…tor/api/reconciler/Reconciler.java Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
metacosm
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.