Sonar reported issues #816
Conversation
| import io.javaoperatorsdk.operator.processing.LifecycleAware; | ||
|
|
||
| @SuppressWarnings("rawtypes") | ||
| public class Operator implements AutoCloseable, LifecycleAware { |
There was a problem hiding this comment.
@metacosm this Autoclosable is a little bit confusing here since start is not blocking, removed it, pls let me know what do you think.
There was a problem hiding this comment.
That change will need to be documented because people might be relying on it.
There was a problem hiding this comment.
You mean in migration guide? We don't document changes from v1 -> v2 , just there
csviri
force-pushed
the
sonar-reported-issues
branch
from
c9f32bf to
fb39bbc
Compare
| private final GenericRetry genericRetry; | ||
|
|
||
| private volatile int lastAttemptIndex = 0; | ||
| private AtomicInteger lastAttemptIndex = new AtomicInteger(0); |
There was a problem hiding this comment.
Do we actually have multiple threads accessing that state concurrently?
There was a problem hiding this comment.
checked and atctually don't now, good catch! Changhed it
There was a problem hiding this comment.
Did you push the changes, I don't see them?
| import io.javaoperatorsdk.operator.processing.LifecycleAware; | ||
|
|
||
| @SuppressWarnings("rawtypes") | ||
| public class Operator implements AutoCloseable, LifecycleAware { |
There was a problem hiding this comment.
That change will need to be documented because people might be relying on it.
|
SonarCloud Quality Gate failed. |
|
Let's get this merged! |
Few sonar reported issue fixes