Skip to content

Updates contributing docs #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 4, 2023
Merged

Updates contributing docs #305

merged 3 commits into from
Aug 4, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Jul 17, 2023 •
edited
Loading

Updates contributing docs in line with latest changes made in #284

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2023
@m1kola
Copy link
Member Author

m1kola commented Jul 17, 2023 •
edited
Loading

Lint job is failure is unrelated. See #304

Edit: apart from this one:

External link http://localhost:1313/ failed with something very wrong.
It's possible libcurl couldn't connect to the server, or perhaps the request timed out.
Sometimes, making too many requests at once also breaks things. (status code 0)

Will see if I can make linter ignore it.

@m1kola m1kola force-pushed the update_contributing_docs branch from 93d9a9b to 7ee096b Compare July 17, 2023 13:32
m1kola
m1kola commented Jul 17, 2023
View reviewed changes
@m1kola m1kola force-pushed the update_contributing_docs branch 3 times, most recently from 016d299 to 7ed0a3e Compare July 18, 2023 14:33
@m1kola m1kola mentioned this pull request Jul 31, 2023
Merged
@m1kola m1kola force-pushed the update_contributing_docs branch 5 times, most recently from 88b05d8 to f791742 Compare July 31, 2023 13:54
@m1kola m1kola requested a review from anik120 July 31, 2023 14:45
Mikalai Radchuk added 3 commits July 31, 2023 16:26
Updates contributing docs
2b39f08 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Makes linter ignore localhost hugo link
ad6dd3f 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Fixes numbered list styling in docs
c68796d 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola force-pushed the update_contributing_docs branch from f791742 to c68796d Compare July 31, 2023 15:26
@m1kola m1kola marked this pull request as ready for review July 31, 2023 15:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2023
perdasilva
perdasilva approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@m1kola m1kola merged commit a825e9d into operator-framework:master Aug 4, 2023
@m1kola m1kola deleted the update_contributing_docs branch August 4, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perdasilva perdasilva perdasilva approved these changes

@everettraven everettraven everettraven approved these changes

@anik120 anik120 Awaiting requested review from anik120

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m1kola @perdasilva @everettraven