-
Notifications
You must be signed in to change notification settings - Fork 66
📖 Adding OLM V1 architecture document #1301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Adding OLM V1 architecture document #1301
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
edcbd6a
to
b4e3796
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
=======================================
Coverage 76.60% 76.60%
=======================================
Files 40 40
Lines 2406 2406
=======================================
Hits 1843 1843
Misses 395 395
Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b4e3796
to
deeeb1e
Compare
The documentation contains description of the components and a diagram. Removed the components.md file as the architecture doc contains the same information Fixes : [operator-framework#1124](operator-framework#1124) Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
deeeb1e
to
8a0beb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I think it's really good. I've made a couple of suggestions and suggested edits. The suggested edits can also probably be improved. By hope they convey what I was thinking. I think we should also call out the CRs each component reconciles (with links to the API description).
Co-authored-by: Per Goncalves da Silva <perdasilva@redhat.com>
Co-authored-by: Per Goncalves da Silva <perdasilva@redhat.com>
Co-authored-by: Per Goncalves da Silva <perdasilva@redhat.com>
Co-authored-by: Per Goncalves da Silva <perdasilva@redhat.com>
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
67c1540
to
3433c16
Compare
@perdasilva I do not want to go to that low level in this document as it would impact the readability of the doc. We can have another doc (as follow up) which can talk about this. So that folks want to go little low level can move to those docs after going through the architecture doc. |
I get that. I just would have expected the API the users use to not really be a low level thing. It's the front door XD |
@perdasilva We already have #1230 and #1240. So I am not entirely sure what you are looking for. If you can create an issue with more details/context I can take a look to fix it. |
The documentation contains description of the components and a diagram. Removed the components.md file as the architecture doc contains the same information
Fixes : #1124
Description
Reviewer Checklist