Skip to content

📖 Adding OLM V1 architecture document #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

LalatenduMohanty
Copy link
Member

The documentation contains description of the components and a diagram. Removed the components.md file as the architecture doc contains the same information

Fixes : #1124

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@LalatenduMohanty LalatenduMohanty requested a review from a team as a code owner September 23, 2024 19:07
Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 3433c16
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66f2b6c08fb8550008abc119
😎 Deploy Preview https://deploy-preview-1301--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LalatenduMohanty LalatenduMohanty force-pushed the arch-docs branch 2 times, most recently from edcbd6a to b4e3796 Compare September 23, 2024 19:14
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.60%. Comparing base (62b5c53) to head (3433c16).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1301   +/-   ##
=======================================
  Coverage   76.60%   76.60%           
=======================================
  Files          40       40           
  Lines        2406     2406           
=======================================
  Hits         1843     1843           
  Misses        395      395           
  Partials      168      168           
Flag Coverage Δ
e2e 58.14% <ø> (ø)
unit 53.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The documentation contains description of the components and a diagram.
Removed the components.md file as the architecture doc contains the same
information

Fixes : [operator-framework#1124](operator-framework#1124)

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I think it's really good. I've made a couple of suggestions and suggested edits. The suggested edits can also probably be improved. By hope they convey what I was thinking. I think we should also call out the CRs each component reconciles (with links to the API description).

LalatenduMohanty and others added 5 commits September 24, 2024 08:40
Co-authored-by: Per Goncalves da Silva <perdasilva@redhat.com>
Co-authored-by: Per Goncalves da Silva <perdasilva@redhat.com>
Co-authored-by: Per Goncalves da Silva <perdasilva@redhat.com>
Co-authored-by: Per Goncalves da Silva <perdasilva@redhat.com>
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@LalatenduMohanty
Copy link
Member Author

LalatenduMohanty commented Sep 24, 2024

I think we should also call out the CRs each component reconciles (with links to the API description).

@perdasilva I do not want to go to that low level in this document as it would impact the readability of the doc. We can have another doc (as follow up) which can talk about this. So that folks want to go little low level can move to those docs after going through the architecture doc.

@LalatenduMohanty LalatenduMohanty added this pull request to the merge queue Sep 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 24, 2024
@LalatenduMohanty LalatenduMohanty added this pull request to the merge queue Sep 25, 2024
Merged via the queue into operator-framework:main with commit d1a4dbf Sep 25, 2024
18 checks passed
@perdasilva
Copy link
Contributor

I think we should also call out the CRs each component reconciles (with links to the API description).

@perdasilva I do not want to go to that low level in this document as it would impact the readability of the doc. We can have another doc (as follow up) which can talk about this. So that folks want to go little low level can move to those docs after going through the architecture doc.

I get that. I just would have expected the API the users use to not really be a low level thing. It's the front door XD

@LalatenduMohanty
Copy link
Member Author

@perdasilva We already have #1230 and #1240.

So I am not entirely sure what you are looking for. If you can create an issue with more details/context I can take a look to fix it.

@LalatenduMohanty LalatenduMohanty deleted the arch-docs branch September 25, 2024 13:55
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Overall architecture documentation
3 participants