🌱 move service to kustomize manager dir, rename for general purpose use #1544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joelanford
force-pushed
the
move-rename-service
branch
from
24be992 to
c4a6850
Compare
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
move-rename-service
branch
from
c4a6850 to
6702698
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1544 +/- ##
=======================================
Coverage 74.25% 74.25%
=======================================
Files 42 42
Lines 3329 3329
=======================================
Hits 2472 2472
Misses 676 676
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
camilamacedo86
pushed a commit
to camilamacedo86/operator-controller
that referenced
this pull request
Jan 6, 2025
…operator-framework#1544) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
camilamacedo86
pushed a commit
to camilamacedo86/operator-controller
that referenced
this pull request
Jan 6, 2025
…operator-framework#1544) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
camilamacedo86
pushed a commit
to camilamacedo86/operator-controller
that referenced
this pull request
Jan 6, 2025
…operator-framework#1544) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
camilamacedo86
pushed a commit
to camilamacedo86/operator-controller
that referenced
this pull request
Jan 6, 2025
…operator-framework#1544) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
camilamacedo86
pushed a commit
to camilamacedo86/operator-controller
that referenced
this pull request
Jan 6, 2025
…operator-framework#1544) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
camilamacedo86
pushed a commit
to camilamacedo86/operator-controller
that referenced
this pull request
Jan 6, 2025
…operator-framework#1544) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
camilamacedo86
pushed a commit
to camilamacedo86/operator-controller
that referenced
this pull request
Jan 8, 2025
…operator-framework#1544) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
camilamacedo86
pushed a commit
to camilamacedo86/operator-controller
that referenced
this pull request
Jan 8, 2025
…operator-framework#1544) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames the internal operator-controller service from "operator-controller-controller-manager-metrics-service" to "operator-controller-service".
It also moves the service kustomize manifest from the
rbacbase to themanagerbase.Reviewer Checklist