🌱Deleting pprof files as these are not relevant now #1806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LalatenduMohanty
changed the title
|
I was just looking at this. The README.md file indicates the data is old. Do we still want to keep it around? |
|
/hold As I am checking if we can delete these files |
openshift-ci
bot
added
the
do-not-merge/hold
LalatenduMohanty
force-pushed
the
move_pprof_dir
branch
from
1dfda4d to
caf6e4e
Compare
These got added in operator-framework/catalogd#3 but we are not using them and have different plans for permance bench marking. Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty
force-pushed
the
move_pprof_dir
branch
from
caf6e4e to
f260206
Compare
LalatenduMohanty
changed the title
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Updated the PR to remove/delete these files. |
anik120
approved these changes
Feb 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1806 +/- ##
==========================================
+ Coverage 68.34% 68.39% +0.05%
==========================================
Files 62 62
Lines 5117 5117
==========================================
+ Hits 3497 3500 +3
+ Misses 1390 1388 -2
+ Partials 230 229 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting pprof files as these are not relevant now
These got added in operator-framework/catalogd#3
but we are not using them and have different plans for permance
bench marking.
Description
Reviewer Checklist