Skip to content

🌱 crd-generator annotation text: generated -> generator #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joelanford
Copy link
Member

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford joelanford requested a review from a team as a code owner July 3, 2025 20:25
Copy link

netlify bot commented Jul 3, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 89157ee
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6866e96489616b00082481ac
😎 Deploy Preview https://deploy-preview-2074--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested review from dtfranz and kevinrizza July 3, 2025 20:25
@tmshort
Copy link
Contributor

tmshort commented Jul 3, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2025
Copy link

openshift-ci bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2025
@tmshort
Copy link
Contributor

tmshort commented Jul 3, 2025

Unit test is failing because the test data needs to be updated.

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford force-pushed the generator-annotation-name branch from 3403101 to 89157ee Compare July 3, 2025 20:34
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2025
@tmshort
Copy link
Contributor

tmshort commented Jul 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2025
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.24%. Comparing base (14b3eda) to head (89157ee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2074      +/-   ##
==========================================
- Coverage   73.29%   73.24%   -0.06%     
==========================================
  Files          77       77              
  Lines        7056     7056              
==========================================
- Hits         5172     5168       -4     
- Misses       1543     1546       +3     
- Partials      341      342       +1     
Flag Coverage Δ
e2e 44.98% <ø> (-0.05%) ⬇️
experimental-e2e 51.25% <ø> (-0.05%) ⬇️
unit 58.20% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort tmshort merged commit 3d3ffd5 into operator-framework:main Jul 3, 2025
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants