Ensure the platform operator stack is deployed before running e2e tests #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: timflannagan <timflannagan@gmail.com>
timflannagan
commented
May 26, 2022
| # Use distroless as minimal base image to package the manager binary | ||
| # Refer to https://github.com/GoogleContainerTools/distroless for more details | ||
| FROM gcr.io/distroless/static:nonroot | ||
| FROM gcr.io/distroless/static:debug-nonroot |
There was a problem hiding this comment.
Update from the debug tag that matched the rukpak container image to debug-nonroot as I ran into the following error locally:
container has runasnonroot and image will run as root
And that's because kubebuilder/operator-sdk automatically scaffold out that securityContext for our manager resources by default (and we didn't use that SDK tooling in rukpak).
timflannagan
commented
May 26, 2022
Comment on lines
+117
to
+118
| // TODO(tflannag): properly handle multiple catalogsources in a cluster | ||
| cs := css.Items[0] |
There was a problem hiding this comment.
This is a super short term hack that's needed in order to work with the basic e2e tests that I have sitting locally, which deploy a magic catalog instance, so hardcoding the CatalogSource reference, and even worse hardcode that logic at the main.go level as it fails the container at startup, wouldn't work with that setup.
timflannagan
force-pushed
the
update-dockerfile
branch
from
b25879f to
19acd4d
Compare
timflannagan
changed the title
timflannagan
changed the title
awgreene
pushed a commit
to awgreene/operator-controller
that referenced
this pull request
Oct 13, 2023
…-limits UPSTREAM: 290: Remove Resource Limits (operator-framework#290)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Home for any commits that are needed in order to get a basic e2e testing suite introduced.