🌱 Add basic webhook support e2e #2108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
perdasilva
force-pushed
the
webhook-e2e
branch
3 times, most recently
from
d26c5a6 to
57f0463
Compare
added 2 commits
July 17, 2025 15:58
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2108 +/- ##
==========================================
+ Coverage 73.55% 73.65% +0.09%
==========================================
Files 78 78
Lines 7260 7260
==========================================
+ Hits 5340 5347 +7
+ Misses 1568 1564 -4
+ Partials 352 349 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm I like your idea of moving some of the shared logic in the e2e tests into a shared library in a future issue/PR. |
|
Look at those experimental-e2e results! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 5786e67
into
operator-framework:main
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #2107 to pass
Adds a basic webhook support e2e to the experimental e2e suite.
We should consider building a little e2e test library as there will be much re-use between the tests and the streams (standard, experimental, etc.). Alternatively, maybe we should consider not having multiple e2e test suites and use labels or some other artifice to to structure/select what gets run in which scenario. This might also make it easier to re-use helper functions and always ensure that the e2e suite is concise and consistent as features graduate.
Reviewer Checklist