🌱 promote rukpak hash util to shared package, use in boxcutter applier #2201
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2201 +/- ##
==========================================
+ Coverage 71.95% 72.17% +0.22%
==========================================
Files 85 85
Lines 8436 8407 -29
==========================================
- Hits 6070 6068 -2
+ Misses 1959 1939 -20
+ Partials 407 400 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| encoder := json.NewEncoder(hasher) | ||
| if err := encoder.Encode(obj); err != nil { | ||
| return "", fmt.Errorf("couldn't encode object: %w", err) | ||
| panic(fmt.Sprintf("couldn't encode object: %v", err)) |
There was a problem hiding this comment.
Why do we want this to panic? Seems a bit excessive?
There was a problem hiding this comment.
|
/approve |
perdasilva
force-pushed
the
fix-deep-hash-object
branch
from
66293ac to
0216a7a
Compare
| }, | ||
| } | ||
| defaultDesiredHash := "705ada5296ab26f74d94bfa497295a0cbccdb140623bbe704a3506cd1dfba4eb" | ||
| defaultDesiredHash := "gvvp8nzq5sbila80hkiv69am8hdr7o68qkk8n084gdn" |
There was a problem hiding this comment.
could the change in hash cause problems with existing installed content after upgrade?
There was a problem hiding this comment.
I guess if the upgrade CI job passed, we're good...?
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva, thetechnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
tmshort
force-pushed
the
fix-deep-hash-object
branch
from
0216a7a to
2e16ac7
Compare
|
I rebased this to deal with go.mod/go.sum changes. |
openshift-merge-bot
bot
merged commit 4867f92
into
operator-framework:main
Description
Reviewer Checklist