✨ CER Previous Limit #2204
✨ CER Previous Limit #2204
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2204 +/- ##
==========================================
- Coverage 72.09% 71.98% -0.12%
==========================================
Files 85 85
Lines 8401 8457 +56
==========================================
+ Hits 6057 6088 +31
- Misses 1941 1961 +20
- Partials 403 408 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
You may need to rebase to get past the |
dtfranz
force-pushed
the
boxcutter-revision-limit
branch
from
0686423 to
33610fa
Compare
Thanks! It's passing now. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Should the title be |
dtfranz
force-pushed
the
boxcutter-revision-limit
branch
3 times, most recently
from
331cc7c to
55ed73c
Compare
|
|
||
| // setPreviousRevisions populates spec.previous of latestRevision, trimming the list of previous _archived_ revisions down to | ||
| // ClusterExtensionRevisionPreviousLimit or to the first _active_ revision and deletes trimmed revisions from the cluster | ||
| func (bc *Boxcutter) setPreviousRevisions(ctx context.Context, latestRevision *ocv1.ClusterExtensionRevision, revisionList []ocv1.ClusterExtensionRevision) error { |
There was a problem hiding this comment.
should we call out that we expect revisionList to be sorted by revision number?
There was a problem hiding this comment.
Good call, I'll add a comment here!
Sets a limit to the number of previous ClusterExtensionRevisions we keep in the cluster, and trims the list of previous revisions when creating new revisions to stay at the limit. The limit has been set to 5 for now. Any revisions beyond this limit will be removed from the cluster. Signed-off-by: Daniel Franz <dfranz@redhat.com>
dtfranz
force-pushed
the
boxcutter-revision-limit
branch
from
55ed73c to
b640387
Compare
|
/lgtm |
openshift-merge-bot
bot
merged commit 8c42457
into
operator-framework:main
3 participants
Sets a limit to the number of previous
ClusterExtensionRevisionswe keep in the cluster, and trims the list of previous revisions when creating new revisions to stay at the limit. The limit has been set to 5 for now. Any revisions beyond this limit will be removed from the cluster EDIT: unless they are active.Description
Reviewer Checklist