-
Notifications
You must be signed in to change notification settings - Fork 66
🌱 OPRUN-4101: Move helm converter to applier package #2207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 OPRUN-4101: Move helm converter to applier package #2207
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2207 +/- ##
==========================================
+ Coverage 72.09% 72.11% +0.01%
==========================================
Files 85 85
Lines 8401 8437 +36
==========================================
+ Hits 6057 6084 +27
- Misses 1941 1948 +7
- Partials 403 405 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
You may need to rebase to get past the |
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
0ae5b9d
to
191bf91
Compare
/approve |
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ed3bdcf
into
operator-framework:main
Description
First part in a series of refactor PRs that aim to modularize and harmonize the way ClusterExtensions get converted into the appliers unit of deployment (i.e. Chart or revision). In this PR, we frame the registry+v1 to Chart converter as an implementation of a
HelmChartProvider
(oldBundleToHelmChartConverter
) calledRegistryV1HelmChartProvider
and remove therukpak/convert
package.In the next PR, we'll introduce a
HelmBundleChartProvider
that can handle Helm Chart bundles and remove the feature gate check from the (helm-based) applier itself.In further PRs we'll re-implement the
RegistryV1HelmChartProvider
using theRegistryV1BundleRenderer
in boxcutter.go to generate to objects from that, generate the chart - reducing code duplication and separating concerns a bit better.Reviewer Checklist