Skip to content

Conversation

perdasilva
Copy link
Contributor

Description

First part in a series of refactor PRs that aim to modularize and harmonize the way ClusterExtensions get converted into the appliers unit of deployment (i.e. Chart or revision). In this PR, we frame the registry+v1 to Chart converter as an implementation of a HelmChartProvider (old BundleToHelmChartConverter) called RegistryV1HelmChartProvider and remove the rukpak/convert package.

In the next PR, we'll introduce a HelmBundleChartProvider that can handle Helm Chart bundles and remove the feature gate check from the (helm-based) applier itself.

In further PRs we'll re-implement the RegistryV1HelmChartProvider using the RegistryV1BundleRenderer in boxcutter.go to generate to objects from that, generate the chart - reducing code duplication and separating concerns a bit better.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva perdasilva requested a review from a team as a code owner September 10, 2025 15:58
Copy link

netlify bot commented Sep 10, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit f721a07
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68c3dae7ba9ca4000860d6a5
😎 Deploy Preview https://deploy-preview-2207--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.11%. Comparing base (1821160) to head (f721a07).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
internal/operator-controller/applier/provider.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2207      +/-   ##
==========================================
+ Coverage   72.09%   72.11%   +0.01%     
==========================================
  Files          85       85              
  Lines        8401     8437      +36     
==========================================
+ Hits         6057     6084      +27     
- Misses       1941     1948       +7     
- Partials      403      405       +2     
Flag Coverage Δ
e2e 39.05% <41.66%> (-0.35%) ⬇️
experimental-e2e 46.38% <0.00%> (+0.23%) ⬆️
unit 56.77% <66.66%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Contributor

tmshort commented Sep 11, 2025

You may need to rebase to get past the upgrade-experimental-e2e failure.

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@tmshort
Copy link
Contributor

tmshort commented Sep 11, 2025

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2025
@perdasilva perdasilva changed the title 🌱 Move helm converter to applier package 🌱 OPRUN-4101 Move helm converter to applier package Sep 11, 2025
@perdasilva perdasilva changed the title 🌱 OPRUN-4101 Move helm converter to applier package 🌱 OPRUN-4101: Move helm converter to applier package Sep 11, 2025
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2025
Copy link

openshift-ci bot commented Sep 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ed3bdcf into operator-framework:main Sep 12, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants