🐛 OPRUN-4139: Use control-plane selectors in network-policies and tests for now #2218
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Until downstream is ready to use the "app.kubernetes.io/name" selector, continue to use the "control-plane" selector in the tests. Change the network-policies to use a "control-plane" selector (which is still on pods because the Deployment selector is immutable). This includes a revert of "Use old and new pod selectors during kustomize-to-helm transition" This reverts operator-framework#2214 This reverts commit 6e22e2b.
tmshort
force-pushed
the
revert-e2e-fixes
branch
from
184f789 to
4c4684f
Compare
|
If/When I want to go back to |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2218 +/- ##
==========================================
- Coverage 72.06% 72.00% -0.06%
==========================================
Files 85 85
Lines 8401 8453 +52
==========================================
+ Hits 6054 6087 +33
- Misses 1943 1959 +16
- Partials 404 407 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
openshift-merge-bot
bot
merged commit e0a2e17
into
operator-framework:main
Until downstream is ready to use the "app.kubernetes.io/name" selector, continue to use the "control-plane" selector in the tests.
Change the network-policies to use a "control-plane" selector (which is still on pods because the Deployment selector is immutable).
This includes a revert of "Use old and new pod selectors during kustomize-to-helm transition" This reverts #2214
This reverts commit 6e22e2b.
Description
Reviewer Checklist