-
Notifications
You must be signed in to change notification settings - Fork 66
✨ OPRUN-4150: Relax webhook support preconditions #2222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ OPRUN-4150: Relax webhook support preconditions #2222
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2222 +/- ##
==========================================
+ Coverage 72.17% 72.22% +0.04%
==========================================
Files 85 85
Lines 8407 8422 +15
==========================================
+ Hits 6068 6083 +15
Misses 1939 1939
Partials 400 400
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
867b67a
to
16d4286
Compare
internal/operator-controller/rukpak/render/registryv1/validators/validator.go
Show resolved
Hide resolved
internal/operator-controller/rukpak/render/registryv1/validators/validator.go
Outdated
Show resolved
Hide resolved
internal/operator-controller/rukpak/render/registryv1/validators/validator.go
Outdated
Show resolved
Hide resolved
16d4286
to
84adf16
Compare
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
84adf16
to
8b72968
Compare
internal/operator-controller/rukpak/render/registryv1/validators/validator.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
internal/operator-controller/rukpak/render/registryv1/validators/validator.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
internal/operator-controller/rukpak/render/registryv1/validators/validator_test.go
Show resolved
Hide resolved
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, pedjak, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5478ac6
into
operator-framework:main
Description
In OLMv0, only bundles with conversion webhooks must only support AllNamespaces install mode. In the initial implementation of the v1 support, we temporarily extended this to all webhook types. This PR brings v1 inline with v0 webhook support.
The PR also adds the
CheckConversionWebhookSupport
to the validator (which should have been done originally, but seems to have slipped)Reviewer Checklist