Skip to content

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Sep 16, 2025

Description

In OLMv0, only bundles with conversion webhooks must only support AllNamespaces install mode. In the initial implementation of the v1 support, we temporarily extended this to all webhook types. This PR brings v1 inline with v0 webhook support.

The PR also adds the CheckConversionWebhookSupport to the validator (which should have been done originally, but seems to have slipped)

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva perdasilva requested a review from a team as a code owner September 16, 2025 09:34
@openshift-ci openshift-ci bot requested a review from bentito September 16, 2025 09:34
Copy link

netlify bot commented Sep 16, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 362b58e
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68cbb979a7941800083b1e14
😎 Deploy Preview https://deploy-preview-2222--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested a review from joelanford September 16, 2025 09:34
@perdasilva perdasilva changed the title ✨ OPRUN-4150: Relax webhook preconditions ✨ OPRUN-4150: Relax webhook support preconditions Sep 16, 2025
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.22%. Comparing base (27b05e7) to head (362b58e).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2222      +/-   ##
==========================================
+ Coverage   72.17%   72.22%   +0.04%     
==========================================
  Files          85       85              
  Lines        8407     8422      +15     
==========================================
+ Hits         6068     6083      +15     
  Misses       1939     1939              
  Partials      400      400              
Flag Coverage Δ
e2e 39.16% <12.50%> (+0.03%) ⬆️
experimental-e2e 46.32% <62.50%> (+0.17%) ⬆️
unit 57.08% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva perdasilva force-pushed the relax-webhook-preconds branch from 867b67a to 16d4286 Compare September 16, 2025 09:51
@perdasilva perdasilva force-pushed the relax-webhook-preconds branch from 16d4286 to 84adf16 Compare September 16, 2025 13:45
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva force-pushed the relax-webhook-preconds branch from 84adf16 to 8b72968 Compare September 16, 2025 13:48
Per G. da Silva added 4 commits September 17, 2025 10:50
Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2025
@tmshort
Copy link
Contributor

tmshort commented Sep 19, 2025

/approve

Copy link

openshift-ci bot commented Sep 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, pedjak, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 5478ac6 into operator-framework:main Sep 19, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants