Skip to content

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Sep 16, 2025

Description

With #2166 and #2163 in place, annotation based config support can be removed.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@anik120 anik120 requested a review from a team as a code owner September 16, 2025 15:14
Copy link

netlify bot commented Sep 16, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 53b0f1a
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68cacb1dc188390008055398
😎 Deploy Preview https://deploy-preview-2224--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@anik120 anik120 requested review from perdasilva and removed request for OchiengEd and rashmigottipati September 16, 2025 15:21
@anik120 anik120 force-pushed the config-api-remove-annotations-support branch from 3e6b542 to aa86ff1 Compare September 16, 2025 15:30
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.20%. Comparing base (27b05e7) to head (53b0f1a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2224      +/-   ##
==========================================
+ Coverage   72.17%   72.20%   +0.02%     
==========================================
  Files          85       85              
  Lines        8407     8405       -2     
==========================================
+ Hits         6068     6069       +1     
+ Misses       1939     1937       -2     
+ Partials      400      399       -1     
Flag Coverage Δ
e2e 39.21% <ø> (+0.08%) ⬆️
experimental-e2e 46.21% <ø> (+0.06%) ⬆️
unit 57.00% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

namespace: argocd-system
serviceAccount:
name: argocd-installer
config:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some more nuance now with the defaults configuration. Depending on the install modes supported, we'd have different behaviors here. E.g. if the bundle only supports OwnNamespace, you wouldn't specify the watchNamespace. Have you checked the demos still work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I've made a few extra changes and put them in a separate commit 53b0f1a, demos work perfectly now.

With operator-framework#2166 and operator-framework#2163 in place, annotation based config support can be removed.

Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
@anik120 anik120 force-pushed the config-api-remove-annotations-support branch from aa86ff1 to 53b0f1a Compare September 17, 2025 14:52
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2025
Copy link

openshift-ci bot commented Sep 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 8016fbd into operator-framework:main Sep 17, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants