-
Notifications
You must be signed in to change notification settings - Fork 66
⚠ OPRUN-4106: remove support for annotation based config #2224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠ OPRUN-4106: remove support for annotation based config #2224
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
3e6b542
to
aa86ff1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2224 +/- ##
==========================================
+ Coverage 72.17% 72.20% +0.02%
==========================================
Files 85 85
Lines 8407 8405 -2
==========================================
+ Hits 6068 6069 +1
+ Misses 1939 1937 -2
+ Partials 400 399 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
namespace: argocd-system | ||
serviceAccount: | ||
name: argocd-installer | ||
config: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some more nuance now with the defaults configuration. Depending on the install modes supported, we'd have different behaviors here. E.g. if the bundle only supports OwnNamespace, you wouldn't specify the watchNamespace. Have you checked the demos still work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. I've made a few extra changes and put them in a separate commit 53b0f1a, demos work perfectly now.
With operator-framework#2166 and operator-framework#2163 in place, annotation based config support can be removed. Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
aa86ff1
to
53b0f1a
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8016fbd
into
operator-framework:main
Description
With #2166 and #2163 in place, annotation based config support can be removed.
Reviewer Checklist