🌱 OPRUN-4138 Remove no-op patch strategy tags and markers #2225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pedjak
changed the title
pedjak
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2225 +/- ##
==========================================
- Coverage 72.17% 72.05% -0.12%
==========================================
Files 85 85
Lines 8407 8407
==========================================
- Hits 6068 6058 -10
- Misses 1939 1948 +9
- Partials 400 401 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/approve |
openshift-ci
bot
added
the
approved
pedjak
changed the title
* `+patchStrategy` and `+patchMergeKey` markers are not supported by controller-gen, see https://github.com/kubernetes-sigs/controller-tools/tree/main/pkg/crd/markers * `patchStrategy` and `patchMergeKey` golang tags are of no use for CRDs. They have their use in k8s core types in order to produce proper strategic merge patches, see https://github.com/kubernetes/community/blob/master/contributors/devel/sig-api-machinery/strategic-merge-patch.md but are superseded by `+listType` and `+listMapKey` in CRD world. It removal, as expected, did not provide any effect on the generated resources.
pedjak
force-pushed
the
remove-no-op-tags
branch
from
3e910cc to
0b37f75
Compare
perdasilva
approved these changes
Sep 17, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 9af2eff
into
operator-framework:main
25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
+patchStrategyand+patchMergeKeymarkers are not supported by controller-gen, seehttps://github.com/kubernetes-sigs/controller-tools/tree/main/pkg/crd/markers
patchStrategyandpatchMergeKeygolang tags are of no use for CRDs. They have their usein k8s core types in order to produce proper strategic merge patches, see
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-api-machinery/strategic-merge-patch.md
but are superseded by
+listTypeand+listMapKeyin CRD world.Their removal, as expected, did not provide any effect on the generated resources.
Part of OPRUN-4138
Reviewer Checklist