🌱 OPRUN-4138 Load CRDs for envtests from chart directory #2232
Conversation
Followup of operator-framework#2145: given that `config` folder is going to be removed soon, `internal/operator-controller/controllers/suite_test.go` loads CRDs from `helm/olmv1/base/operator-controller/crd`. Creation of `envtest.Environment` moved and consolidated into `test/utils.go` so that it can be consumed by multiple test suites.
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2232 +/- ##
==========================================
- Coverage 72.16% 71.84% -0.33%
==========================================
Files 85 86 +1
Lines 8440 8474 +34
==========================================
- Hits 6091 6088 -3
- Misses 1948 1984 +36
- Partials 401 402 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 47f8d31
into
operator-framework:main
2 participants
Description
Followup of #2145: given that
configfolder is going to be removed soon,internal/operator-controller/controllers/suite_test.goloads CRDs fromhelm/olmv1/base/operator-controller/crd.Creation of
envtest.Environmentmoved and consolidated intotest/utils.goso that it can be consumed by multiple test suites.
Reviewer Checklist