🌱 Move kube-rbac-proxy into base manager yaml #695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
❌ Deploy Preview for olmv1 failed.
|
m1kola
commented
Mar 13, 2024
Comment on lines
+31
to
+46
| affinity: | ||
| nodeAffinity: | ||
| requiredDuringSchedulingIgnoredDuringExecution: | ||
| nodeSelectorTerms: | ||
| - matchExpressions: | ||
| - key: kubernetes.io/arch | ||
| operator: In | ||
| values: | ||
| - amd64 | ||
| - arm64 | ||
| - ppc64le | ||
| - s390x | ||
| - key: kubernetes.io/os | ||
| operator: In | ||
| values: | ||
| - linux |
There was a problem hiding this comment.
This is not new: we already have affinity (see deleted config/default/manager_auth_proxy_patch.yaml).
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
everettraven
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Having
kube-rbac-proxyin a separate patch makes working with manager args confusing. We either have to include all args into that patch (e.g. like--feature-gates=ForceSemverUpgradeConstraints=truewas added) or have a separate patch to override args.Since we have always have
kube-rbac-proxyenabled anyway - why not move it into the base manager manifest?Reviewer Checklist