Skip to content

Conversation

jmrodri
Copy link
Member

@jmrodri jmrodri commented Jul 26, 2020

No description provided.

@coveralls
Copy link

coveralls commented Jul 26, 2020

Pull Request Test Coverage Report for Build 186104794

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.244%

Totals Coverage Status
Change from base Build 184469623: 0.0%
Covered Lines: 275
Relevant Lines: 386

💛 - Coveralls

Makefile Outdated
check-license: $(SOURCES)
@./hack/check-license.sh "$(SOURCES)"

fake:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need the fake one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because I was experimenting and forgot to delete it :)

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@jmrodri jmrodri merged commit 2fbf2f8 into operator-framework:main Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants