Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: catalog source polling for updated registry image #1161

Merged
merged 3 commits into from Jan 10, 2020
Merged

feat: catalog source polling for updated registry image #1161

merged 3 commits into from Jan 10, 2020

Conversation

exdx
Copy link
Member

@exdx exdx commented Dec 2, 2019 •
edited by ecordell

Description of the change:
Branch consolidates implementation of catalog polling feature that continues from #1109.

Motivation for the change:
New feature request. Part of https://github.com/openshift/enhancements/blob/master/enhancements/olm/operator-registry.md.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@exdx exdx requested a review from dinhxuanvu December 2, 2019 19:36
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 2, 2019
@exdx exdx mentioned this pull request Dec 2, 2019
Closed
5 tasks
njhale
njhale reviewed Dec 12, 2019
View reviewed changes
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job so far!

I took some notes on my thoughts -- will re-review when it's out of WIP.

pkg/api/apis/operators/catalogsource_types.go Outdated Show resolved Hide resolved
pkg/api/apis/operators/v1alpha1/catalogsource_types.go Show resolved Hide resolved
deploy/chart/templates/0000_50_olm_06-catalogsource.crd.yaml Outdated Show resolved Hide resolved
pkg/api/apis/operators/v1alpha1/catalogsource_types.go Outdated Show resolved Hide resolved
pkg/api/apis/operators/v1alpha1/catalogsource_types.go Outdated Show resolved Hide resolved
pkg/controller/registry/reconciler/grpc.go Outdated Show resolved Hide resolved
pkg/controller/registry/reconciler/grpc.go Outdated Show resolved Hide resolved
pkg/controller/registry/reconciler/grpc.go Outdated Show resolved Hide resolved
pkg/controller/registry/reconciler/grpc.go Outdated Show resolved Hide resolved
@exdx exdx force-pushed the feat/catalog-polling branch 2 times, most recently from e6a5297 to 6041410 Compare December 16, 2019 20:54
@exdx exdx requested a review from njhale December 16, 2019 22:44
ecordell
ecordell reviewed Dec 17, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@exdx exdx changed the title [WIP] feat: catalog source polling feat: catalog source polling for updated registry image Dec 17, 2019
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 17, 2019
@exdx exdx requested a review from ecordell December 17, 2019 20:16
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2019
@exdx
Copy link
Member Author

exdx commented Dec 18, 2019

/retest

@exdx exdx force-pushed the feat/catalog-polling branch 2 times, most recently from a13c7b8 to de7b1ff Compare December 18, 2019 20:14
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 19, 2019
@exdx
Copy link
Member Author

exdx commented Dec 20, 2019

e2e now works locally (with skopeo installed)

@exdx
Copy link
Member Author

exdx commented Jan 8, 2020

/test unit

@dinhxuanvu
Copy link
Member

/retest

@exdx
Copy link
Member Author

exdx commented Jan 9, 2020

/retest

@exdx
Copy link
Member Author

exdx commented Jan 9, 2020

/test e2e-gcp

@exdx
Copy link
Member Author

exdx commented Jan 9, 2020

/test unit

1 similar comment
@exdx
Copy link
Member Author

exdx commented Jan 9, 2020

/test unit

@exdx
Copy link
Member Author

exdx commented Jan 9, 2020

/test e2e-aws-olm

@dinhxuanvu
Copy link
Member

/retest

@exdx
Copy link
Member Author

exdx commented Jan 10, 2020

/test e2e-gcp

@exdx
Copy link
Member Author

exdx commented Jan 10, 2020

/test e2e-aws-console-olm

@exdx
Copy link
Member Author

exdx commented Jan 10, 2020

/test e2e-aws-olm

@exdx
Copy link
Member Author

exdx commented Jan 10, 2020

/test e2e-gcp

2 similar comments
@exdx
Copy link
Member Author

exdx commented Jan 10, 2020

/test e2e-gcp

@exdx
Copy link
Member Author

exdx commented Jan 10, 2020

/test e2e-gcp

@ecordell
Copy link
Member

/lgtm

as discussed, we'll have follow up PRs for:

  • cleaning up the logging
  • removing quay creds
  • updating the API definition in response to comments here

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, exdx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
@exdx
Copy link
Member Author

exdx commented Jan 10, 2020

/retest

1 similar comment
@exdx
Copy link
Member Author

exdx commented Jan 10, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit 7053452 into operator-framework:master Jan 10, 2020
@exdx exdx deleted the feat/catalog-polling branch January 11, 2020 02:27
@exdx exdx mentioned this pull request Jan 13, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@jpeeler jpeeler Awaiting requested review from jpeeler

@njhale njhale Awaiting requested review from njhale

@ecordell ecordell Awaiting requested review from ecordell

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@exdx @ecordell @dinhxuanvu @openshift-ci-robot @njhale @openshift-merge-robot